Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(zod-openapi): extract range definitions to StatusCode #535

Merged
merged 2 commits into from
May 23, 2024

Conversation

taku-hatano
Copy link
Contributor

fixes #534

Copy link

changeset-bot bot commented May 20, 2024

🦋 Changeset detected

Latest commit: f6fd5cc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@hono/zod-openapi Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@yusukebe yusukebe changed the title fix(zod-openapi): extract range definitions to StatusCode feat(zod-openapi): extract range definitions to StatusCode May 22, 2024
@yusukebe
Copy link
Member

Hi @taku-hatano !

Awesome!! This is a super cool feature, and the implementation is good!

One thing I would like you to do; this is a new feature, so make it a minor change instead of a patch. Thanks!

@taku-hatano
Copy link
Contributor Author

Thanks for your comment, @yusukebe !

I have made minor change.
Please check!

Copy link
Member

@yusukebe yusukebe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@yusukebe
Copy link
Member

@taku-hatano

Thanks for the cool feature! Shipping it now.

@yusukebe yusukebe merged commit a595e4e into honojs:main May 23, 2024
1 check passed
This was referenced May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[zod-openapi] Make range definitions available
2 participants