update server definition #352
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryuapp
reviewed
May 16, 2024
Comment on lines
+187
to
+189
| const untypedServer = server as unknown as any | ||
| untypedServer.ip = server.requestIP(req) | ||
| return app.fetch(req, untypedServer) |
There was a problem hiding this comment.
I don't know if regressions will occur, but it is better to pass only ip to env now.
Suggested change
| const untypedServer = server as unknown as any | |
| untypedServer.ip = server.requestIP(req) | |
| return app.fetch(req, untypedServer) | |
| const ip = server.requestIP(req) | |
| return app.fetch(req, {ip}) |
There was a problem hiding this comment.
I tried and still have the error that is mentionned
honojs/hono#2645 (comment)
Or maybe we can wait for this issue
honojs/hono#2696
const ip = server.requestIP(req)
return app.fetch(req, {ip})
Comment on lines
+69
to
+71
| const untypedServer = server as unknown as any | ||
| untypedServer.ip = server.requestIP(req) | ||
| return app.fetch(req, untypedServer); |
There was a problem hiding this comment.
Suggested change
| const untypedServer = server as unknown as any | |
| untypedServer.ip = server.requestIP(req) | |
| return app.fetch(req, untypedServer); | |
| const ip = server.requestIP(req) | |
| return app.fetch(req, {ip}) |
|
@mathysth This has been fixed in 4.4.0. There is now a ConnInfo Helper to get the IP address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update how the server is defined because it could introduce regressions for some Bun HTTP features.
honojs/hono#2645 (comment)