Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Select mpi_lib loading mode by default to adapt different platform #3964

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Select mpi_lib loading mode by default to adapt different platform #3964

wants to merge 1 commit into from

Conversation

Lifann
Copy link

@Lifann Lifann commented Jul 18, 2023 •
edited

Checklist before submitting

  • [ x ] Did you read the contributor guide?
  • Did you update the docs?
  • Did you write any tests to validate this change?
  • Did you update the CHANGELOG, if this change affects users?

Description

This PR use default mode in ctypes.CDLL to adapt to different platform.

Fixes #3936

Review process to land

  1. All tests and other checks must succeed.
  2. At least one member of the technical steering committee must review and approve.
  3. If any member of the technical steering committee requests changes, they must be addressed.

fix: Select mpi_lib loading mode by default to adapt different platform
b914938 
Signed-off-by: oppenheimli <oppenheimli@tencent.com>
@Lifann Lifann force-pushed the choose-mpi_lib-by-default branch from 9732651 to b914938 Compare July 18, 2023 10:59
@Lifann Lifann mentioned this pull request Jul 18, 2023
Open
@stale
Copy link

stale bot commented Sep 17, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Sep 17, 2023
@maxhgerlach maxhgerlach self-requested a review September 18, 2023 08:45
@stale stale bot removed the wontfix label Sep 18, 2023
@stale Stale
Copy link

stale bot commented Dec 15, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxhgerlach maxhgerlach Awaiting requested review from maxhgerlach

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
wontfix
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HorovodBasics load dynamic library make grpc create channel failed with tensorflow-2.11
1 participant
@Lifann