Spellcheck, fix docs for R CMD check, rebuild pkgdown #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alistaire47
commented
Feb 11, 2022
| @@ -90,7 +91,6 @@ ipsum <- function(number_sections = FALSE, | |||
| clean_supporting = self_contained, | |||
| pre_processor = pre_processor, | |||
| base_format = rmarkdown::html_document_base( | |||
| smart = smart, | |||
There was a problem hiding this comment.
This is the one code change. Since this is getting passed through to ... and ignored, it should not affect behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Saw a typo on the pkgdown, figured I'd make a quick PR, and things escalated to a bit more housekeeping-type stuff. I see there are some similar PRs already, but they're years old and would need a messy rebase and update, so I figured it's easier just to start from scratch. If this PR gets to be that old, feel free to decline it.
What this does:
a. One notable change here is deprecating the
smartparam ofipsum(), because it gets passed tormarkdown::html_document_base()which is ignoring it. Can handle this differently if you like, but it had to be documented somehow for R CMD check to pass.a. I did add a truly minimal
_pkgdown.ymlwith the URL linked from this repo (https://cinc.rud.is/web/packages/hrbrthemes/), though it looks like it's also hosted on gh pages (https://hrbrmstr.github.io/hrbrthemes/). That file can be reverted or changed if desired.