-
-
Notifications
You must be signed in to change notification settings - Fork 242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Swagger UI Config #1051
base: master
Are you sure you want to change the base?
Update Swagger UI Config #1051
Conversation
|
||
internal class MapDelegate<T>( | ||
private val properties: MutableMap<String, UiProperty<out Any>>, | ||
private val name: String, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this value? the name does come in through the get/set value methods (as a part of the property) so we can probably get away without it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
THe only place we need it is for dom_id
, unless we're ok breaking backwards compatibility by changing the property name to match.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1051 +/- ##
============================================
- Coverage 84.66% 84.62% -0.04%
+ Complexity 1999 1995 -4
============================================
Files 578 579 +1
Lines 13180 13192 +12
Branches 1724 1727 +3
============================================
+ Hits 11159 11164 +5
- Misses 1227 1230 +3
- Partials 794 798 +4 ☔ View full report in Codecov by Sentry. |
Tests are finally passing 😅 |
null