Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update loading.mdx to include "jsonl" file loading. #6647

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

mosheber
Copy link

@mosheber mosheber commented Feb 7, 2024

  • A small update to the documentation, noting the ability to load jsonl files.

Copy link
Member

@albertvillanova albertvillanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the explicit loading command.

However, I would move it just below, where we present the JSON-Lines example.

  • Maybe adding that this format is called JSON-Lines
  • Add the example after the JSON-Lines data example

```json
{"a": 1, "b": 2.0, "c": "foo", "d": false}
{"a": 4, "b": -5.5, "c": null, "d": true}
```

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@mosheber
Copy link
Author

mosheber commented Feb 8, 2024

Thanks for adding the explicit loading command.

However, I would move it just below, where we present the JSON-Lines example.

  • Maybe adding that this format is called JSON-Lines
  • Add the example after the JSON-Lines data example

```json
{"a": 1, "b": 2.0, "c": "foo", "d": false}
{"a": 4, "b": -5.5, "c": null, "d": true}
```

Thank you @albertvillanova for the feedback! I moved the jsonl file loading example to a more appropriate location.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants