Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Persist IterableDataset epoch in workers #6710

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

lhoestq
Copy link
Member

@lhoestq lhoestq commented Mar 2, 2024

Use shared memory for the IterableDataset epoch.

This way calling ds.set_epoch() in the main process will update the epoch in the DataLoader workers as well.
This is useful especially because the epoch is used to compute the effective_seed used for shuffling.

I used torch's shared memory in case users want to send dataset copies without shared memory using pickle. I also find it easier to use than using multiprocessing.shared_memory than requires unlinking only in the main process, or mp.Value that is not picklable.

close #6673

cc @rwightman

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IterableDataset set_epoch is ignored when DataLoader persistent_workers=True
2 participants