Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Ernie model #1753

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

BrightXiaoHan
Copy link

@BrightXiaoHan BrightXiaoHan commented Mar 11, 2024

Solve #555
This submission enables optimum to support the Ernie family model and support onnxruntime export of related models. The onnx code related to this model has been verified.

https://github.com/huggingface/transformers/tree/main/src/transformers/models/ernie

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

Copy link
Collaborator

@fxmarty fxmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you, waiting for the tests to run

Two things:

@fxmarty
Copy link
Collaborator

fxmarty commented Mar 19, 2024

@BrightXiaoHan Could you add ernie as well to

"esm": "hf-internal-testing/tiny-random-EsmModel",
? Also can you use https://huggingface.co/hf-internal-testing/tiny-random-ErnieModel instead of https://huggingface.co/hf-internal-testing/tiny-random-ErnieMModel? They appear to be two different model types in transformers and the test currently fail due to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants