-
Notifications
You must be signed in to change notification settings - Fork 25.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Idefics2] Improve docs, add resources #30717
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding to and updating the docs!
Feel free to approve and merge |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for iterating! Just a small nit
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
9a7c7e3
to
99c9e4f
Compare
* Add resources * Address comment * Address comments * Update docs/source/en/model_doc/idefics2.md Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com> * Update figure --------- Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
What does this PR do?
This PR fixes the code snippet of Idefics2, adds links to resources and explains how to optimize the model using Flash Attention/quantization.