Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Idefics2] Improve docs, add resources #30717

Merged
merged 5 commits into from
May 16, 2024

Conversation

NielsRogge
Copy link
Contributor

What does this PR do?

This PR fixes the code snippet of Idefics2, adds links to resources and explains how to optimize the model using Flash Attention/quantization.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding to and updating the docs!

docs/source/en/model_doc/idefics2.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/idefics2.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/idefics2.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/idefics2.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/idefics2.md Outdated Show resolved Hide resolved
docs/source/en/model_doc/idefics2.md Outdated Show resolved Hide resolved
@NielsRogge
Copy link
Contributor Author

Feel free to approve and merge

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for iterating! Just a small nit

docs/source/en/model_doc/idefics2.md Outdated Show resolved Hide resolved
NielsRogge and others added 2 commits May 13, 2024 17:18
Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
@NielsRogge NielsRogge merged commit 17cc71e into huggingface:main May 16, 2024
8 checks passed
itazap pushed a commit that referenced this pull request May 24, 2024
* Add resources

* Address comment

* Address comments

* Update docs/source/en/model_doc/idefics2.md

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>

* Update figure

---------

Co-authored-by: amyeroberts <22614925+amyeroberts@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants