Blip dynamic input resolution #30722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
amyeroberts
reviewed
May 9, 2024
| inputs = processor(images=image, return_tensors="pt").to(torch_device) | ||
|
|
||
| predictions = model.generate(**inputs, interpolate_pos_encoding=True) | ||
| self.assertEqual(predictions[0].tolist(), [30522, 1037, 2450, 3564, 2006, 1996, 3509, 2007, 1037, 3899, 102]) |
There was a problem hiding this comment.
Have you checked the generated ids here to make sure they make sense for the picture i.e.:
processor.batch_decode([30522, 1037, 2450, 3564, 2006, 1996, 3509, 2007, 1037, 3899, 102])
|
@amyeroberts good point! the tests now also have a check for the textual content. |
amyeroberts
approved these changes
May 13, 2024
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds ability to handle dynamic input image resolutions to the BLIP family of models.
Addresses #30579
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Ping: @amyeroberts