Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workflow: Replace actions/post-slack with centrally defined workflow #30737

Merged
merged 2 commits into from May 13, 2024

Conversation

younesbelkada
Copy link
Contributor

@younesbelkada younesbelkada commented May 10, 2024

What does this PR do?

Cleans up a bit our actions repo by replacing the actions/post-slack workflow with the centrally defined one in huggingface/hf-workflows repository

cc @amyeroberts

@younesbelkada younesbelkada changed the title Workflow: Remove commit details Workflow: Remove commit details for the post-slack workflow May 10, 2024
@younesbelkada
Copy link
Contributor Author

younesbelkada commented May 10, 2024

Actually i might just remove that workflow completely in favor of: huggingface/hf-workflows#9 and use that centrally on all our HF repos

@amyeroberts
Copy link
Collaborator

Actually i might just remove that workflow completely in favor of: huggingface/hf-workflows#9 and use that centrally on all our HF repos

OK, let me know what you decide and if you still want a review. My vote would be for a more central, unified workflow. FWIW, we shouldn't need to adapt ci runs here because of other libraries - it hints at unnecessary dependencies

@younesbelkada
Copy link
Contributor Author

thanks, yes I agree, just waiting for @glegendre01 's review on that PR and I will modify this PR to use that centralized GHA instead 🙏 will ping you once all is set!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@younesbelkada younesbelkada changed the title Workflow: Remove commit details for the post-slack workflow Workflow: Replace actions/post-slack with centrally defined workflow May 13, 2024
@younesbelkada
Copy link
Contributor Author

cc @amyeroberts this is ready for review!

Copy link
Collaborator

@amyeroberts amyeroberts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! It's always nice to see lots of code deleted :D

@younesbelkada younesbelkada merged commit a4e530e into main May 13, 2024
8 checks passed
@younesbelkada younesbelkada deleted the younesbelkada-patch-1 branch May 13, 2024 10:08
@ArthurZucker
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants