New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated logic and warnings #30743
Remove deprecated logic and warnings #30743
Conversation
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup! A few nits here and there and we'll be good to go
@@ -395,11 +394,6 @@ def forward( | |||
output_attentions: bool = False, | |||
**kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**kwargs, |
@@ -551,14 +545,6 @@ def forward( | |||
output_attentions: bool = False, | |||
**kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**kwargs, |
@@ -789,11 +775,6 @@ def forward( | |||
output_attentions: bool = False, | |||
**kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
**kwargs, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here kwargs needs to be removed
@property | ||
def sin_cached(self): | ||
logger.warning_once( | ||
"The sin_cached attribute will be removed in 4.39. Bear in mind that its contents changed in v4.38. Use " | ||
"the forward method of RoPE from now on instead. It is not used in the `LlamaAttention` class" | ||
) | ||
return self._sin_cached | ||
|
||
@property | ||
def cos_cached(self): | ||
logger.warning_once( | ||
"The cos_cached attribute will be removed in 4.39. Bear in mind that its contents changed in v4.38. Use " | ||
"the forward method of RoPE from now on instead. It is not used in the `LlamaAttention` class" | ||
) | ||
return self._cos_cached | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the buffers that are registered need to be deleted as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comments as for llama!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same comment as llama
@ArthurZucker Thanks for the review! I've removed all of the kwargs being passed now, and the |
fe89540
to
76cfebe
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 🤗
What does this PR do?
Kills a bunch of deprecated code