Rewrote your local build instructions! #3201
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Thought your local build instructions could use some help. It's bloated and filled with sections that could lead to errors. It's also missing a bunch of pre-requisites which might derail newcomers.
DATABASE_ADAPTER=postgresql
in every shell command is unnecessary. The user should update this variable directly from the.env
file along with the DB username and password. Also, if the user prepends the command and disregards updating.env
, the application will fail to start as.env
defaults to mysql..env
.I've simplified the local build instructions. Let me know what you guys think!
I believe these changes will help your users especially newbies who might be looking to use Huginn!