Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid web request encode error #3336

Merged
merged 2 commits into from May 16, 2024
Merged

avoid web request encode error #3336

merged 2 commits into from May 16, 2024

Conversation

clfsoft
Copy link
Contributor

@clfsoft clfsoft commented Nov 29, 2023 •
edited

when access some malform encoded website .
website agent stop working by throwing exception

fix by replacing unknow ,invalid char sequence to space.

Error when fetching url: "\xFA\xD4" from EUC-JP to UTF-8
/app/app/concerns/web_request_concern.rb:56:in `encode!'

Encoding+Options

@clfsoft clfsoft changed the title avoid web requeset encode error avoid web request encode error Nov 29, 2023
@clfsoft clfsoft mentioned this pull request Nov 29, 2023
Open
@clfsoft
Copy link
Contributor Author

clfsoft commented Nov 29, 2023

related issues
#3215

@knu knu merged commit 62cc663 into huginn:master May 16, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knu knu knu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clfsoft @knu