ci: Remove executor.wasm from git #4553
Conversation
Signed-off-by: Shanin Roman <shanin1000@yandex.ru>
|
@BAStos525 ci change for building and providing executor for tests |
|
Shouldn't proceed before figuring out how to ship executor for iroha deployment. |
| - uses: actions/checkout@v4 | ||
| - uses: Swatinem/rust-cache@v2 | ||
| - name: Build iroha executor | ||
| run: cargo run --bin iroha_wasm_builder_cli -- build ./default_executor --optimize --outfile configs/swarm/executor.wasm |
There was a problem hiding this comment.
| run: cargo run --bin iroha_wasm_builder_cli -- build ./default_executor --optimize --outfile configs/swarm/executor.wasm | |
| run: cargo run --release --bin iroha_wasm_builder_cli -- build ./default_executor --optimize --outfile configs/swarm/executor.wasm |
should it run in release mode?
There was a problem hiding this comment.
probably doesn't metter since it will build iroha_wasm_builder, actual executor always builds in release mode
There was a problem hiding this comment.
This PR removes executor.wasm, but doesn't change anything about genesis.json, which still has "executor_file": "./executor.wasm".
One of the intentions behind having the WASM blob stored in Git is to allow users "just open the repo and run docker compose up". Perhaps we need to revise this use case in some way, in its root. Until then, this PR breaks things.
Description
Remove
executor.wasmfrom git, executor is built in the CI.Linked issue
Closes #4549