-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc(hyprctl): enhance hyprctl help messages #3368
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good but for me the dot at the end of a command (monitors:
) is to much cluter. Consider just writing monitors
hyprctl --batch {<command 1> [args] ; <command 2> [args] ; ...} | ||
|
||
LISTING COMMANDS: | ||
monitors: List outputs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why are the :
everywhere?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They probably took the style of writing from their language.
For the same purpose that you use "->" for
getoption <option>: Get value of <option> | ||
reload: Reload configurations | ||
|
||
PLUGIN: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plugins makes more sense
plugin unload <path>: Unload plugin at <path> | ||
|
||
THEMING: | ||
hyprpaper <keywords> Issue hyprpaper keywords using IPC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hyprpaper should not be in theming, maybe a separate category called "integrations"?
const std::string USAGE = R"#(usage: hyprctl [flags] [<command> [args]] | ||
hyprctl --batch {<command 1> [args] ; <command 2> [args] ; ...} | ||
|
||
LISTING COMMANDS: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
query commands fits better imo
bb93090
to
3a189c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Vaxry's proposed changes are implemented, I would approve
7110a04
to
25aec3a
Compare
fb471b8
to
1237732
Compare
Addtional Changes