Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xwayland: allow to disable xwayland via config option #3371

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vnepogodin
Copy link

Adds ability to disable xwayland without recompilation with the flag

@vaxerski
Copy link
Member

so it just adds an option but that option aint doing nothin'?

@vnepogodin
Copy link
Author

so it just adds an option but that option aint doing nothin'?

By default yes nothing will happen, because by default xwayland is enabled.

If you add:

xwayland {
  enabled = false
}

Then it wont spawn xwayland.

@vaxerski
Copy link
Member

based on the diff I'd like to contest that statement

@vnepogodin
Copy link
Author

vnepogodin commented Sep 19, 2023

@vaxerski
Copy link
Member

well, add it then maybe? :)

@vnepogodin
Copy link
Author

well, add it then maybe? :)

yeah already pushed. sry haha

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outside of this, since xwayland runs in parallel, you'll need to add a function (probably in the config manager) to check the status of xwayland on config reloads.

if someone edits the option, we might want to kill / start xwayland

src/managers/XWaylandManager.cpp Outdated Show resolved Hide resolved
src/managers/XWaylandManager.cpp Outdated Show resolved Hide resolved
@vnepogodin
Copy link
Author

outside of this, since xwayland runs in parallel, you'll need to add a function (probably in the config manager) to check the status of xwayland on config reloads.

if someone edits the option, we might want to kill / start xwayland

well I'd rather restrict editing that option. It should be initiated just once in the lifetime of the program

@vaxerski
Copy link
Member

this is absolutely wrong, as xwayland will naturally be shut down if no xwayland apps are open, anyways (lazy mode in hyprland is always on)

@vnepogodin
Copy link
Author

this is absolutely wrong, as xwayland will naturally be shut down if no xwayland apps are open, anyways (lazy mode in hyprland is always on)

the intention for it is to force everything to native wayland. in lazy mode it will still launch as x11 app if broken detection with happened for it to fallback to xorg, etc

@vaxerski
Copy link
Member

yes, but what I want is for people to be able to dynamically toggle xwayland on / off.

As in, if xwayland is enabled and there are xwayland apps open, and someone disables it, kill xwayland.

force everything to native wayland.

that is done by setenv and unsetenv of $DISPLAY

@vnepogodin
Copy link
Author

yes, but what I want is for people to be able to dynamically toggle xwayland on / off.

As in, if xwayland is enabled and there are xwayland apps open, and someone disables it, kill xwayland.

force everything to native wayland.

that is done by setenv and unsetenv of $DISPLAY

well yeah I can look into that

@h0tc0d3
Copy link

h0tc0d3 commented Nov 24, 2023

You don’t need any extra parameters, you can do this and xwayland won’t start.

env = WLR_XWAYLAND, /dev/null

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants