-
-
Notifications
You must be signed in to change notification settings - Fork 716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set radius for each window's corner #4386
base: main
Are you sure you want to change the base?
Conversation
Probably not supported by the API but can one add multiple ways of defining variables, vaxry?
|
Yes. I kept the old way of defining rounding with one integer and added a new way with four separated by comma. This
then gets mapped as:
|
@Eclextic already possible. |
This would be a nice addition at least for people who use hyprbars as plugin. |
Pssst... That's what the Author of this MR was eluding to! |
7110a04
to
25aec3a
Compare
fb471b8
to
1237732
Compare
Describe your PR, what does it fix/add?
This PR opens a possibility to define a radius for each window's corner separately. This can come as a new way for ricing Hyprland in combination of modified
hyprwm/hyprland-plugins/hyprbars
(please don't judge color scheming, I set them to have a high contrast).As you can see window has rounded corners only at the bottom and hyprbars only at the top. They become more unified and it actually seems like
hyprbars
is part of the window.Rounding has additional definition:
Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)
However it is not done yet and there are still some issues. For example: window border isn't part of the bar (in picture set to size 7) as it still renders around the original window and not around
hyprbars
.On top of that as you can see (in highlighted red rectangle) the border is rounded even though radius is set to
0
. To keep it consistent there shouldn't be any rounding.When merged it will break
hyprwm/hyprland-plugins/hyprbars
andhyprwm/hyprland-plugins/borders-plus-plus
as they rely onCWindow::rounding()
and not the changedCWindow::getCornerRadii()
.Also I'm not sure if substraction box for renderdata.damage has correct values. I've left a
TODO
comment there.Is it ready for merging, or does it need work?
PR is not ready for merging. I just wanted to see if it's a valid feature to add into
Hyprland
and if there's any interest for it.If it will be decided to merge this, I'll make another PR into
hyprwm/hyprland-plugins
to fix compatibility and rounding.