Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change min cursor padding to 0 #6027

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

drendog
Copy link
Contributor

@drendog drendog commented May 11, 2024

Describe your PR, what does it fix/add?

Since ed411f5 a padding has been added to the cursor, which means that some application that expect a hit in the window border bounds, will never detects the hit there.
For example when using firefox at full screen mode, that expect a hit on top of the windows to show the hidden tabs, it will never detects the hit.

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

ed411f5 #5902

Is it ready for merging, or does it need work?

Ready

@Agent00Ming
Copy link
Contributor

Agent00Ming commented May 11, 2024

but my scroll bar 😭 #5902 (comment) (JK, but this could be turned into a per-side config maybe)

Copy link
Contributor

@Agent00Ming Agent00Ming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Firefox fullscreen functionality is reduced by the 1 pixel minimum. This does indeed fix it.

@vaxerski
Copy link
Member

wouldnt it be better to add a setting to have the padding only on the bottom right?

@morr0ne
Copy link
Contributor

morr0ne commented May 14, 2024

wouldnt it be better to add a setting to have the padding only on the bottom right?

Maybe I am not understanding this right, but what is the purpose of the padding? It mainly seems to break stuff.

@Agent00Ming
Copy link
Contributor

wouldnt it be better to add a setting to have the padding only on the bottom right?

Maybe I am not understanding this right, but what is the purpose of the padding? It mainly seems to break stuff.

#5902 (comment) and #5902 (comment) should explain the reason behind it.

@morr0ne
Copy link
Contributor

morr0ne commented May 17, 2024

Okay after reading through the pr I understand the purpose of the padding. However it feels like it should default to 0 and then users affected can add the 1px padding themselves. If this gets released as is most desktop users will end up with a broken config by default without even knowing why.

+1 for this pr

@vaxerski
Copy link
Member

vaxerski commented May 17, 2024

I still think this is the wrong solution and instead #6027 (comment) should be done

@morr0ne
Copy link
Contributor

morr0ne commented May 17, 2024

I still think this is the wrong solution and instead #6027 (comment) should be done

That could be a solution. Regardless this should be considered a blocker for 0.41.0 until resolved imo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants