Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to change position of HyprError bar (#3241) #6111

Merged
merged 1 commit into from
May 17, 2024

Conversation

zjeffer
Copy link
Contributor

@zjeffer zjeffer commented May 16, 2024

Describe your PR, what does it fix/add?

Implements my own feature request: #3241.

Many people have their system bar up top. This means that when they have a config error, the error goes above the bar.
Depending on your set error_limit, the errors might also cover up things like the top of your browser (which you might want to use to search for help), or the top of your terminal (which is where your prompt, and you'll use that to fix the error).

This PR makes the position configurable:

  • top bar (current): debug:error_position = 0 (default)
  • bottom bar: debug:error_position = 1 (or I guess it would work with any non-zero value).

Is there anything you want to mention? (unchecked code, possible bugs, found problems, breaking compatibility, etc.)

Tested in a nested debug instance. No problems found.

I would actually argue the default should be bottom, as I think more people have their bar up top than at the bottom. I assume the top is default for a reason?

Is it ready for merging, or does it need work?

Before merging this, I need to create a wiki PR to explain the new option. I'll create that after I get approval for this PR.

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks! wiki mr needed

@vaxerski vaxerski merged commit 0cb8fbe into hyprwm:main May 17, 2024
8 of 10 checks passed
@zjeffer zjeffer deleted the hyprerror-bar-position branch May 17, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants