Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes iawia002/lux#1121 #1129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fixes iawia002/lux#1121 #1129

wants to merge 1 commit into from

Conversation

Sfrisio
Copy link

@Sfrisio Sfrisio commented Jul 26, 2022 •
edited by iawia002

fix #1121

@Sfrisio
Copy link
Author

Sfrisio commented Jul 26, 2022

Preliminary check to verify that the FFMPEG package is installed, before performing any other operations, as required in issue #1129

iawia002
iawia002 reviewed Jul 27, 2022
View reviewed changes
Copy link
Owner

@iawia002 iawia002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM

utils/ffmpeg.go Show resolved Hide resolved
main.go Show resolved Hide resolved
@Sfrisio Sfrisio requested a review from iawia002 October 4, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iawia002 iawia002 Awaiting requested review from iawia002

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check for FFMPEG before video download (not fail after)
2 participants
@Sfrisio @iawia002