Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: add dailymotion support #523

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP: add dailymotion support #523

wants to merge 3 commits into from

Conversation

joeke80215
Copy link
Contributor

No description provided.

@joeke80215
Copy link
Contributor Author

PTAL

@iawia002
Copy link
Owner

Can you update the supported sites section in README?

@joeke80215
Copy link
Contributor Author

done

iawia002
iawia002 reviewed Mar 11, 2020
View reviewed changes
README.md Outdated
@@ -599,6 +599,7 @@ Pornhub | <https://pornhub.com> | ✓ | | | |
XVIDEOS | <https://xvideos.com> | ✓ | | | |
聯合新聞網 | <https://udn.com> | ✓ | | | |
TikTok | <https://www.tiktok.com> | ✓ | | | |
Dailymotion | <www.dailymotion.com> | ✓ | | | |
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Dailymotion | <www.dailymotion.com> | ✓ | | | |
Dailymotion | <https://www.dailymotion.com> | ✓ | | | |

@iawia002
Copy link
Owner

Is the extract method really usable, why the size of the video is so small, eg:

 Site:      Dailymotion dailymotion.com
 Title:     安妮朵拉 Anniedora - 孤獨的自由 Freedom of Solitude (官方歌詞 Lyric MV)
 Type:      video
 Streams:   # All available quality
     [auto]  -------------------
     Quality:         auto
     Size:            0.01 MiB (6804 Bytes)
     # download with: annie -f auto ...

@joeke80215
Copy link
Contributor Author

Is the extract method really usable, why the size of the video is so small, eg:

 Site:      Dailymotion dailymotion.com
 Title:     安妮朵拉 Anniedora - 孤獨的自由 Freedom of Solitude (官方歌詞 Lyric MV)
 Type:      video
 Streams:   # All available quality
     [auto]  -------------------
     Quality:         auto
     Size:            0.01 MiB (6804 Bytes)
     # download with: annie -f auto ...

I will check again,tks

@joeke80215 joeke80215 changed the title add dailymotion support WIP: add dailymotion support Mar 11, 2020
@iawia002 iawia002 force-pushed the master branch 4 times, most recently from dccdfc5 to de872ac Compare May 29, 2020 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iawia002 iawia002 iawia002 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joeke80215 @iawia002