feat: Use Last-Modified header to set the file mtime by default #589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iawia002
reviewed
Jan 2, 2020
downloader/downloader.go
Outdated
| @@ -67,6 +67,12 @@ func writeFile( | |||
| if copyErr != nil && copyErr != io.EOF { | |||
| return written, fmt.Errorf("file copy error: %s", copyErr) | |||
| } | |||
| if !config.NoMTime { | |||
There was a problem hiding this comment.
这个不应该写在这儿，一次下载这个可能会被调用很多次，放到 Save 里，等下载完成了再操作这个
|
我又改了一发，有空可以帮忙看一眼 |
iawia002
force-pushed
the
master
branch
4 times, most recently
from
dccdfc5
to
de872ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://github.com/ytdl-org/youtube-dl/blob/master/youtube_dl/options.py#L732