Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve client delete issue #1027

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Syed-Sharful-Islam-Sifat
Copy link

@Syed-Sharful-Islam-Sifat Syed-Sharful-Islam-Sifat commented Mar 26, 2024

Description

Not being able to delete client despite the absence of invoices or quotes for that client. gave a corrected check so that client can be deleted if there is no quotes or invoices

Screenshots

Before:

idurar error message

After:

idurar success message

Fixes #1025

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

@Syed-Sharful-Islam-Sifat Syed-Sharful-Islam-Sifat changed the title fix: resolve client delete issue #1025 fix: resolve client delete issue (Fixes #1025) Mar 26, 2024
@Syed-Sharful-Islam-Sifat
Copy link
Author

Syed-Sharful-Islam-Sifat commented Apr 14, 2024

@salahlalami @inesmrad Is there any problem with the changes I have made or any formalities that I did not fulfill?

@Syed-Sharful-Islam-Sifat Syed-Sharful-Islam-Sifat changed the title fix: resolve client delete issue (Fixes #1025) fix: resolve client delete issue Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants