Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added indicator box to TUI that follows focused pane #303

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Added indicator box to TUI that follows focused pane #303

wants to merge 4 commits into from

Conversation

danschwarz
Copy link
Collaborator

image

image

@danschwarz
Copy link
Collaborator Author

danschwarz commented Feb 1, 2023 •
edited

image

Not sure what's going on with the failing tests. They fail on my local system also. This PR has been brought up to date with master so includes your latest changes to output.py. For what it's worth, this same test fails in master on my local system.

@ihabunek
Copy link
Owner

ihabunek commented Feb 1, 2023 via email

@ihabunek
Copy link
Owner

ihabunek commented Feb 2, 2023

This works, but I kinda hate to lose the 1 character padding around each pane. :'( Let me think on it a bit.

@danschwarz
Copy link
Collaborator Author

That is a drawback. I run with --relative-datetimes to gain back the columns lost. But not everyone is going to want to do that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@danschwarz @ihabunek