Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Displaying code on the website #91

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

SteakFisher
Copy link
Contributor

Fix for #88

@netlify
Copy link

netlify bot commented Oct 11, 2023

Deploy Preview for algos-web ready!

Name Link
🔨 Latest commit 39a2cbd
🔍 Latest deploy log https://app.netlify.com/sites/algos-web/deploys/6537a376fcee76000853f41c
😎 Deploy Preview https://deploy-preview-91--algos-web.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AniModi
Copy link
Member

AniModi commented Oct 16, 2023

The pages look fine, but since you mentioned about the GitHub API limit, you may do one thing, when the API request fails for whatsoever reason, redirect the users to GitHub page of the code, like we have been doing currently. Also, tag me or the react maintainers after doing so.

@SteakFisher
Copy link
Contributor Author

@AniModi should be good now, I've setup a redirect in the catch block

@SteakFisher
Copy link
Contributor Author

@AniModi bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants