Add log message containing Xcode version #4863
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit will: - Add a key com.colliderli.iina.build.sdk to Info.plist with a value giving the macOS SDK version used when generating the executable - Add a key com.colliderli.iina.build.xcode to Info.plist with a value giving the Xcode version used when generating the executable - Add buildSDK and buildXcode properties to InfoDictionary to provide access to this information - Add logging of the Xcode and macOS SDK versions to logBuildDetails in AppDelegate This information is useful as AppKit behavior can change based on the version of the macOS SDK an application was built with.
|
The startup log message now looks like: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will:
com.colliderli.iina.build.sdktoInfo.plistwith a value giving the macOS SDK version used when generating the executablecom.colliderli.iina.build.xcodetoInfo.plistwith a value giving the Xcode version used when generating the executablebuildSDKandbuildXcodeproperties toInfoDictionaryto provide access to this informationlogBuildDetailsinAppDelegateThis information is useful as AppKit behavior can change based on the version of the macOS SDK an application was built with.
Description: