Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Add Microservices shared database pattern (#2667) #2758

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

nuxchristopher
Copy link

Microservices shared database pattern (#2667)

Pull request description

  • sample java code with javadoc
  • test code
  • UML diagram
  • README.md file

@nuxchristopher nuxchristopher marked this pull request as ready for review October 29, 2023 07:22
@sonarcloud
Copy link

sonarcloud bot commented Oct 29, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug E 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 27 Code Smells

5.3% 5.3% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link

stale bot commented Nov 29, 2023

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Nov 29, 2023
Copy link

stale bot commented Jan 13, 2024

Closed due to inactivity. Thank you for your contributions.

@stale stale bot closed this Jan 13, 2024
@iluwatar iluwatar reopened this Feb 25, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Feb 25, 2024
Copy link
Owner

@iluwatar iluwatar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just a few minor comments and the conflict needs to be resolved.

@@ -0,0 +1,49 @@
@startuml
interface com.iluwater.microservices.shared.database.IOrderService {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be com.iluwatar

Comment on lines 14 to 18
<properties>
<maven.compiler.source>17</maven.compiler.source>
<maven.compiler.target>17</maven.compiler.target>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
</properties>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are defined on the parent level, can be left out

Comment on lines +7 to +11
/**
* Entry point for the shared database microservice application.
* This application is configured to exclude the default DataSource auto-configuration as
* it is using a custom database configuration.
*/
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explain the pattern briefly here. Then describe how the example code implements it.

Copy link

sonarcloud bot commented Feb 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
11.6% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

Copy link

stale bot commented Mar 26, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Mar 26, 2024
@stale stale bot removed the status: stale issues and pull requests that have not had recent interaction label Mar 29, 2024
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

Copy link

stale bot commented Apr 28, 2024

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the status: stale issues and pull requests that have not had recent interaction label Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: stale issues and pull requests that have not had recent interaction status: under review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants