New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Add Microservices shared database pattern (#2667) #2758
base: master
Are you sure you want to change the base?
feature: Add Microservices shared database pattern (#2667) #2758
Conversation
SonarCloud Quality Gate failed. 3 Bugs 5.3% Coverage Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Closed due to inactivity. Thank you for your contributions. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks really good! Just a few minor comments and the conflict needs to be resolved.
@@ -0,0 +1,49 @@ | |||
@startuml | |||
interface com.iluwater.microservices.shared.database.IOrderService { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be com.iluwatar
<properties> | ||
<maven.compiler.source>17</maven.compiler.source> | ||
<maven.compiler.target>17</maven.compiler.target> | ||
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding> | ||
</properties> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are defined on the parent level, can be left out
/** | ||
* Entry point for the shared database microservice application. | ||
* This application is configured to exclude the default DataSource auto-configuration as | ||
* it is using a custom database configuration. | ||
*/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explain the pattern briefly here. Then describe how the example code implements it.
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Quality Gate failedFailed conditions See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Microservices shared database pattern (#2667)
Pull request description