New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactored changes for seperated-interface #2881
base: master
Are you sure you want to change the base?
Conversation
Seems to contain changes for several patterns. Could you make a separe PR for each? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate PR for each pattern refactoring needed
hey @drishtii7, The code style does not follow the google style that project use. See: https://github.com/iluwatar/java-design-patterns/wiki/12.-IDE-instructions You can run the checkstyle checks using IDE plugin or using the command line (mvn validate). |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
What problem does this PR solve?
For the method getTaxPercentage introduced in the DomesticTaxCalculator and ForeignTaxCalculator classes, and it's common to both classes. I have pull this method up to a superclass named AbstractTaxCalculator.