Duplicate counts and write to file #92
Conversation
…es after attempting to upload to the server. Added functionality to write those duplicate file names to a file
|
bin/index.ts
Outdated
| if (res.data && res.data.duplicate) { | ||
| const filePathSplit = asset.filePath.split('/'); | ||
| duplicates.push(filePathSplit[filePathSplit.length-1]); | ||
| return; |
There was a problem hiding this comment.
This return probably breaks the album feature. I think it would work fine without the return.
There was a problem hiding this comment.
I returned there because I did not want it to delete local asset and was not sure if it should proceed with anything else if it is a duplicate. Let me know your thoughts
There was a problem hiding this comment.
I think if they set delete to true it should delete the files when they've been backed up to the server.
It probably doesn't make sense to log the output of duplicates when delete is used though.
There was a problem hiding this comment.
I have feelings against deleting the asset if its identified as a duplicate. I feel like it technically has not been backed up to the server and should not be deleted. Its either already on there or like in my case google created a bunch of duplicates of the same file and it matched to the original that was uploaded. Logging these cases out so that investigation can happen I feel is what I would want at least. I can remove the return and disable the delete if duplicate, or just remove the return and let it delete.
I'll let you make the decision.
There was a problem hiding this comment.
The only situation that can cause duplicate: true is if the file, byte for byte, exists exactly on the server. I personally never use the CLI with the delete option, so I don't really care one way or the other, but I would expect it to delete it (which is what it does today btw - this is existing functionality).
…es if the delete flag is added. Added assumeYes to the question if they want to create a duplicates file, if the flag is present. Change the output to the duplicates file to be the full file path
|
Commit added, not sure if I need to do anything in this pull request to get them to be added. They show in the commits list. |
Fix type Co-authored-by: Jason Rasmussen <jrasm91@gmail.com>
Added functionality to count how many files were reported as duplicates after attempting to upload to the server. Added functionality to write those duplicate file names to a file