Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mobile): ios - do not auto lock on foreground backup setting #7777

Closed
wants to merge 5 commits into from

Conversation

shenlong-tanwen
Copy link
Member

Changes made

  • A new iOS specific app setting to not put the device to sleep when an active foreground backup is in progress. This is useful for initial bulk upload without the user needing to change the device level setting to keep the device alive during backup

Copy link

cloudflare-pages bot commented Mar 9, 2024

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 231a931
Status: ✅  Deploy successful!
Preview URL: https://f2acb898.immich.pages.dev
Branch Preview URL: https://feat-mobile-ios-wakelock.immich.pages.dev

View logs

@dvbthien176
Copy link

dvbthien176 commented Mar 9, 2024

Hi @shenlong-tanwen, thanks for your pull request. I have an ideal: when turn on disable auto lock screen, the device should automatically change to a black display after 5 minutes of idle state to save battery, similar Amazon Photos work to disable auto lock screen. Below is an example screen from Amazon Photos. What do you think of it? Thanks
Ảnh màn hình 2024-03-09 lúc 21 01 37Ảnh màn hình 2024-03-09 lúc 21 39 49

@shenlong-tanwen
Copy link
Member Author

Hi @shenlong-tanwen, thanks for your pull request. I have an ideal: when turn on disable auto lock screen, the device should automatically change to a black display to save battery, similar Amazon Photos work to disable auto lock screen.

This seems like an entire page dedicated to over night uploads. We can even replace my current implementation with a specific route such as from your example to handle over night uploads, yes. This should also make it trivial on which page the app would not sleep. I'll wait for the opinion of others as well before switching the implementation. Thanks a lot for the input!

@aviv926
Copy link
Contributor

aviv926 commented Mar 9, 2024

Hi @shenlong-tanwen, thanks for your pull request. I have an ideal: when turn on disable auto lock screen, the device should automatically change to a black display to save battery, similar Amazon Photos work to disable auto lock screen.

This seems like an entire page dedicated to over night uploads. We can even replace my current implementation with a specific route such as from your example to handle over night uploads, yes. This should also make it trivial on which page the app would not sleep. I'll wait for the opinion of others as well before switching the implementation. Thanks a lot for the input!

If in the end you decide to choose this design, you should pay attention to the thought of moving the elements on this page to avoid the possibility of screen burn.

@DaanHend
Copy link

Hi @shenlong-tanwen, thanks for your pull request. I have an ideal: when turn on disable auto lock screen, the device should automatically change to a black display after 5 minutes of idle state to save battery, similar Amazon Photos work to disable auto lock screen. Below is an example screen from Amazon Photos. What do you think of it? Thanks Ảnh màn hình 2024-03-09 lúc 21 01 37Ảnh màn hình 2024-03-09 lúc 21 39 49

This is a similar as Synology Photos does it. With this app it will count down an turn of the screen. I think after 10 seconds.
Screenshot_20240311-151101

@ddshd
Copy link
Contributor

ddshd commented Mar 11, 2024

My opinion/input: maybe instead of a toggle change it to a button (something like "Overnight Upload") which routes to a mostly blank black screen with just a progress bar and keeping the screen from going to sleep while the upload is running.

Do include something for screen burn though (moving the element at 1 Hz)

@alextran1502
Copy link
Contributor

I am fine with adding this mechanism first in this PR and additional sleep mode in the future PRs

Base automatically changed from refactor/mobile-backup-settings to refactor/mobile-settings March 12, 2024 03:08
@alextran1502
Copy link
Contributor

@shenlong-tanwen Tested, it works well and looks good. Please feel free to merge to the other PR

Base automatically changed from refactor/mobile-settings to main March 12, 2024 14:56
@shenlong-tanwen
Copy link
Member Author

Superseded by #8385

@shenlong-tanwen shenlong-tanwen deleted the feat/mobile-ios-wakelock branch March 30, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants