-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mobile): ios - do not auto lock on foreground backup setting #7777
Conversation
Deploying with Cloudflare Pages
|
Hi @shenlong-tanwen, thanks for your pull request. I have an ideal: when turn on disable auto lock screen, the device should automatically change to a black display after 5 minutes of idle state to save battery, similar Amazon Photos work to disable auto lock screen. Below is an example screen from Amazon Photos. What do you think of it? Thanks |
This seems like an entire page dedicated to over night uploads. We can even replace my current implementation with a specific route such as from your example to handle over night uploads, yes. This should also make it trivial on which page the app would not sleep. I'll wait for the opinion of others as well before switching the implementation. Thanks a lot for the input! |
If in the end you decide to choose this design, you should pay attention to the thought of moving the elements on this page to avoid the possibility of screen burn. |
This is a similar as Synology Photos does it. With this app it will count down an turn of the screen. I think after 10 seconds. |
My opinion/input: maybe instead of a toggle change it to a button (something like "Overnight Upload") which routes to a mostly blank black screen with just a progress bar and keeping the screen from going to sleep while the upload is running. Do include something for screen burn though (moving the element at 1 Hz) |
I am fine with adding this mechanism first in this PR and additional sleep mode in the future PRs |
@shenlong-tanwen Tested, it works well and looks good. Please feel free to merge to the other PR |
Superseded by #8385 |
Changes made