Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): better overall responsiveness #8776

Draft
wants to merge 53 commits into
base: main
Choose a base branch
from

Conversation

Ethan13310
Copy link
Contributor

@Ethan13310 Ethan13310 commented Apr 13, 2024

This PR aims to make the web interface fully responsive.

Overall Changes

  • The page height now correctly matches the view-port height on mobile browsers with dynamic view-port heights (like iOS Safari).
  • Prevents the page from bouncing when over-scrolling on touch devices.
  • The outclick event is now correctly emitted on touch devices.

Sidebar

  • Better animations when opening and closing the sidebar.
  • When the sidebar is partially of fully closed, a button is displayed on the upper left corner (next to the Immich logo) to toggle the sidebar.

(⚠️ Animations have been slowed down to 1s for this video, but are still at 200ms)

(And yes, the slight change of left-margin is made on purpose)

Sidebar.mp4
  • The sidebar is now fully gone on small screens.
Mobile.MP4

Navigation Bar

  • Administration and Toggle Theme buttons have been moved to the account info panel on small screens to prevent the navigation bar from overflowing.
  • The account info panel does not overflow anymore on small screens.

AccountInfoPanel

Work is sill in progress

@alextran1502
Copy link
Contributor

Thank you so much for working on this! I think this is one of the most impact QoL improvements we can do for the web now!

I would love to completely hide the menu on the left unless the user clicks on the hamburger icon. This will open up more real estate for all the views

@aviv926
Copy link
Contributor

aviv926 commented Apr 15, 2024

It looks great.
Is there an option for users to allow the sidebar to be in an open state (previous state) say through Account Settings?
This is a very good use case for older people who can't necessarily understand the meaning of symbols alone.

@Ethan13310
Copy link
Contributor Author

Ethan13310 commented Apr 16, 2024

It looks great. Is there an option for users to allow the sidebar to be in an open state (previous state) say through Account Settings? This is a very good use case for older people who can't necessarily understand the meaning of symbols alone.

The sidebar will remain fully opened on large screens (desktop PCs and laptops). No change here.

It will be displayed in its small state on medium screens (tablets). But in that case, clicking the "hamburger" icon on the top left corner will fully open the sidebar. Hovering the sidebar with your mouse (if any) will also open it.

@Ethan13310 Ethan13310 force-pushed the feat/better-responsiveness branch 3 times, most recently from e48df70 to 51798d4 Compare April 17, 2024 11:09
@NicholasFlamy
Copy link
Contributor

Animations have been slowed down to 1s for this video, but are still at 200ms

If the video from mobile is the normal speed then I really appreciate the really fast animation. I hate slow animations because all they do is slow down productivity.

@Ethan13310 Ethan13310 force-pushed the feat/better-responsiveness branch 2 times, most recently from e86f282 to 7137537 Compare April 21, 2024 09:39
@zackpollard
Copy link
Contributor

Hey, all these changes look great! Haven't done a review of them specifically but just to avoid it getting too large, it might be a good idea to get this PR in a reviewable state soon instead of making even more changes, then we can get it merged and you can continue optimising away after that in a new PR! 😄

@Ethan13310
Copy link
Contributor Author

Hey, all these changes look great! Haven't done a review of them specifically but just to avoid it getting too large, it might be a good idea to get this PR in a reviewable state soon instead of making even more changes, then we can get it merged and you can continue optimising away after that in a new PR! 😄

Yep, indeed! When I'm done I'll split this PR into smaller ones 😃

@NicholasFlamy
Copy link
Contributor

NicholasFlamy commented May 3, 2024

If it isn't too much to ask, could you please provide some more video clips of some of the changes when you get the chance? As teasers for us who look at the PRs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants