fix(server): stacked assets for full sync, userIds as array for delta sync #9100
Conversation
Deploying immich with
|
| Latest commit: |
366d823
|
| Status: | ⚡️ Build in progress... |
server/src/dtos/sync.dto.ts
Outdated
| @ValidateUUID({ each: true }) | ||
| @ApiProperty({ name: 'userIds[]' }) |
There was a problem hiding this comment.
You'd want @IsArray() instead. That also gives you proper validation
There was a problem hiding this comment.
Are you sure? I think, I tried that first. IsArray is already set in the open API json description.
This change makes the client send a single value so that express sees it as an array in any case.
I'll try it again tomorrow just to be sure.
There was a problem hiding this comment.
Apparently you are right, sorry. I think you want both annotations then though, right?
There was a problem hiding this comment.
You should be able to delete the API property without impacting the spec file
There was a problem hiding this comment.
After you delete this line, feel free to merge it.
There was a problem hiding this comment.
This was specifically for a query param, which indeed was needed. I just changed it to post to avoid these types of serialization issues entirely.
server changes required for #8842