feat(server, web): album order preference #9135
Conversation
martabal
force-pushed
the
feat/preference-album-order
branch
from
256202a
to
223e6a7
Compare
Deploying immich with
|
| Latest commit: |
d5d0258
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://65c47480.immich.pages.dev |
| Branch Preview URL: | https://feat-preference-album-order.immich.pages.dev |
martabal
force-pushed
the
feat/preference-album-order
branch
15 times, most recently
from
bf804f1
to
cd16415
Compare
martabal
force-pushed
the
feat/preference-album-order
branch
from
cd16415
to
ae17ea0
Compare
martabal
force-pushed
the
feat/preference-album-order
branch
from
1f7dc5b
to
d14e16e
Compare
| if (order === AssetOrder.PREFERENCE) { | ||
| return enumToOrder[auth.user.preferedAlbumOrder]; | ||
| } |
There was a problem hiding this comment.
This does not need to be in the outer if. You can simply move it in front of it :)
| @@ -40,7 +41,9 @@ export class TimelineService { | |||
| private async buildTimeBucketOptions(auth: AuthDto, dto: TimeBucketDto): Promise<TimeBucketOptions> { | |||
| const { userId, ...options } = dto; | |||
| let userIds: string[] | undefined = undefined; | |||
|
|
|||
| if (dto?.order === AssetOrder.PREFERENCE) { | |||
| options.order = auth.user.preferedAlbumOrder as unknown as AssetOrder; | |||
There was a problem hiding this comment.
What is wrong with those types so that you need to cast it to unknown first?
There was a problem hiding this comment.
It's because we have
export enum AssetOrderPreference {
ASC = 'asc',
DESC = 'desc',
}and
export enum AssetOrder {
ASC = 'asc',
DESC = 'desc',
PREFERENCE = 'preference',
}There was a problem hiding this comment.
AssetOrderPreference is a subset of AssetOrder though, right? I don't understand why TS doesn't get this :D
There was a problem hiding this comment.
Extending an enum would be cool ...
|
Why don't you convert this to ready for review after you have removed the per album/user sorting setting. I think we can keep the default sort order per person, and default to that setting for any new albums, but we don't need per user sort settings for each album. |
Martabal reverted that, no? Afaict this PR now only has (1) default setting per user and (2) sorting order per album (not per album per user). |
|
Yep, I think that's how we decided it to be 🤔 |
The goal is to have a new user settings to choose the default album order (the option is saved in db). The options are
BackwardandForward.Screenshots
User settings :
