Fix Redis Consumption Bug When entrypoint.sh's WS>1 #735
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Description:
#734 I encountered a bug related to Redis consumption under the condition where entrypoint.sh has WS>1.
Cause:
The issue arises from utilizing the same consumer_name across multiple instances, leading to anomalies. For instance, my testing occasionally revealed that tasks successfully dispatched to Redis could fail to be consumed.
This behavior also precipitated additional complications.
Resolution:
To address this, we've implemented a fix by assigning unique consumer_names to the queue_consumer of each thread, effectively mitigating the identified issues and ensuring reliable task consumption from Redis.
Type of change