Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix log_file deadlock, since sync.RWMutex are not reentrant … #23880

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: fix log_file deadlock, since sync.RWMutex are not reentrant … #23880

wants to merge 2 commits into from

Conversation

liuyi1454
Copy link

…(#23816)

Required checklist

  • Signed CLA (if not already signed)

Description

#23816

Severity (delete section if not relevant)

recommend to upgrade immediately

Note for reviewers:

Check the semantic commit type:

  • Feat: a feature with user-visible changes
  • Fix: a bug fix that we might tell a user “upgrade to get this fix for your issue”
  • Chore: version bumps, internal doc (e.g. README) changes, code comment updates, code formatting fixes… must not be user facing (except dependency version changes)
  • Build: build script changes, CI config changes, build tool updates
  • Refactor: non-user-visible refactoring
  • Check the PR title: we should be able to put this as a one-liner in the release notes

@jeffreyssmith2nd jeffreyssmith2nd changed the base branch from 2.5 to master November 9, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffreyssmith2nd jeffreyssmith2nd Awaiting requested review from jeffreyssmith2nd

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@liuyi1454 @jeffreyssmith2nd @liuyicarl