feat: store series ID as bytes using new column type #24902
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #24845
This is PR is in draft, as it is experimental.
This utilizes the experimental changes in
influxdb3_corethat add native support for aSeriesIdcolumn type, that holds a 32-byte array (corresponding PR in core: influxdata/influxdb3_core#12).The change is fairly minimal, if ignoring the
Cargo.lock,Cargo.toml, and a test that needed to be fixed, it is only a 38 LOC change.The test that is failing is due to the fact that the JSON formatter we are using from Datafusion can not handle the
FixedSizeBinaryfield type when writing JSON to the query API response. Interestingly, other formats work, includingpretty/csv, which automatically encode it as HEX.