New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

INN-2864 Render "Function errored" for discovery timeline nodes which fail #1221

Draft

jpwilliams wants to merge 1 commit into main from fix/timeline-error-nodes

Member

jpwilliams commented Mar 8, 2024 •

edited

Description

WIP

When a function with no steps errors but recovers before exhausting retries, create a separate "Function errored" node

Motivation

Type of change (choose one)

Chore (refactors, upgrades, etc.)
Bug fix (non-breaking change that fixes an issue)
Security fix (non-breaking change that fixes a potential vulnerability)
Docs
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality not to work as expected)

Checklist

I've linked any associated issues to this PR.
I've tested my own changes.

Related

INN-2864

Check our Pull Request Guidelines


          Render "Function errored" for discovery timeline nodes which fail

0e15f92

Replacing "..."

jpwilliams added the dev-server-ui label

jpwilliams self-assigned this

vercel bot commented Mar 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
ui	✅ Ready (Inspect)	Visit Preview	Mar 8, 2024 2:05pm

jpwilliams commented

View reviewed changes

ui/packages/components/src/Timeline/TimelineNode/TimelineNodeRenderer.tsx

Comment on lines +95 to +96

		} else if (node.status === 'failed') {
		name = 'Function errored';

Member Author

jpwilliams Mar 8, 2024

This covers the case where a step exhausts all retries and so the error is then thrown to the function itself. This extra check will replace the "..." node with "Function errored".

jpwilliams changed the title ~~Render "Function errored" for discovery timeline nodes which fail~~ INN-2864 Render "Function errored" for discovery timeline nodes which fail

linear bot commented Mar 18, 2024

INN-2864 Hide extra TimelineNode for errored steps that exhausted all retries

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

anafilipadealmeida Awaiting requested review from anafilipadealmeida anafilipadealmeida will be requested when the pull request is marked ready for review anafilipadealmeida is a code owner

goodoldneon Awaiting requested review from goodoldneon goodoldneon will be requested when the pull request is marked ready for review goodoldneon is a code owner

djfarrelly Awaiting requested review from djfarrelly djfarrelly will be requested when the pull request is marked ready for review djfarrelly is a code owner

At least 1 approving review is required to merge this pull request.