Add run details pop out page #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goodoldneon
requested review from
anafilipadealmeida and
djfarrelly
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
djfarrelly
approved these changes
May 9, 2024
Comment on lines
+97
to
+104
| if (isFunctionRunStatus(trace.status)) { | ||
| if (trace.status === 'CANCELLED') { | ||
| text = 'Cancelled'; | ||
| } else if (trace.status === 'COMPLETED') { | ||
| text = 'Completed'; | ||
| } else if (trace.status === 'FAILED') { | ||
| text = 'Failed'; | ||
| } |
There was a problem hiding this comment.
suggestion (non-blocking): Since we're importing a function to check the type then use a switch-like statement to return the text, we could also just put this entire thing into a util fn if we use it in multiple places like: getStatusText(trace.status). Also, it would be ideal to check equality against constants and avoid string matching.
There was a problem hiding this comment.
Where's a good spot for that? ui/packages/components/src/types/functionRun.ts doesn't seem right since the user-facing status text is copy and not a type
Comment on lines
+41
to
+45
| ended: toMaybeDate(trace.endedAt)?.getTime() ?? null, | ||
| max: maxTime.getTime(), | ||
| min: minTime.getTime(), | ||
| queued: new Date(trace.queuedAt).getTime(), | ||
| started: toMaybeDate(trace.startedAt)?.getTime() ?? null, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new
/env/production/runs/[runID]route that shows the new run details. This will be the "pop out" page where users can look at run details outside of the run list.Testing
Type of change (choose one)
Checklist
Check our Pull Request Guidelines