WIP: fixes Python Reference Sidebar #775
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In reference to Aaron's bug report.
The reason the TypeScript nav bar is open is that it has
defaultOpen: true, and currently the logic is that we show the current page's parent navigation AND everything withdefaultOpen: true.This change makes it so that the
defaultOpen: trueelements are only shown as open when there is no currently active route.This may not be what we want, though, because on the "Getting Started" route the "Learn the Basics" section is now closed by default because the "Getting started" route is actually a Next.js subpage under Quickstarts. A solution here is to maybe make a separate landing page for the "Getting Started" route. This would mean, though, that when someone is working through a QuickStart, they don't see the "Getting Started" nav bar. We could move them to be a sub-section the "Getting Started" sidebar, though.