You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There have been many discussions to move our python tooling to ruff, as seen in many popular libraries in the community. This will be a big once-off effort, but will make our pre-commit hooks much faster.
Proposal
Once-off big push to use ruff's tooling. Will need to match current settings to those in ruff in the best way possible.
Testing
Tested by inspection, to see if we're happy with the formatting styles from ruff.
Benchmarking (Optional)
n/a
Definition of done
When ruff is used for our pre-commit hooks in Mava.
Mandatory checklist before making a PR
The success criteria laid down in “Definition of done” are met.
Code is documented - docstrings for methods and classes, static types for arguments.
Code is tested - unit, integration and/or functional tests are added.
Documentation is updated - README, CONTRIBUTING, or other documentation.
All functional tests are green.
Link experiment/benchmarking after implementation (optional).
Feature
There have been many discussions to move our python tooling to ruff, as seen in many popular libraries in the community. This will be a big once-off effort, but will make our pre-commit hooks much faster.
Proposal
Once-off big push to use ruff's tooling. Will need to match current settings to those in ruff in the best way possible.
Testing
Tested by inspection, to see if we're happy with the formatting styles from ruff.
Benchmarking (Optional)
n/a
Definition of done
When ruff is used for our pre-commit hooks in Mava.
Mandatory checklist before making a PR
Links / references / screenshots
https://github.com/astral-sh/ruff
The text was updated successfully, but these errors were encountered: