Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cnn support for recurrent systems #1067

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

feat: cnn support for recurrent systems #1067

wants to merge 8 commits into from

Conversation

SimonDuToit
Copy link
Contributor

Previously it was not possible to use a CNN in Mava's recurrent systems. This PR makes CNNs compatible with recurrent systems and adds a relevant config for a recurrent CNN network.

sash-a
sash-a requested changes Mar 19, 2024
View reviewed changes
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change otherwise looks good. Can we just wait till we've run a couple experiments on connector to see that the recurrent systems perform ok 🙏

mava/networks.py Show resolved Hide resolved
sash-a
sash-a approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@sash-a sash-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SimonDuToit 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sash-a sash-a sash-a approved these changes

@arnupretorius arnupretorius Awaiting requested review from arnupretorius arnupretorius is a code owner

@DriesSmit DriesSmit Awaiting requested review from DriesSmit DriesSmit is a code owner

@RuanJohn RuanJohn Awaiting requested review from RuanJohn RuanJohn is a code owner

@jcformanek jcformanek Awaiting requested review from jcformanek jcformanek is a code owner

@siddarthsingh1 siddarthsingh1 Awaiting requested review from siddarthsingh1 siddarthsingh1 is a code owner

@OmaymaMahjoub OmaymaMahjoub Awaiting requested review from OmaymaMahjoub OmaymaMahjoub is a code owner

@ulricharmel ulricharmel Awaiting requested review from ulricharmel ulricharmel is a code owner

@callumtilbury callumtilbury Awaiting requested review from callumtilbury callumtilbury is a code owner

@WiemKhlifi WiemKhlifi Awaiting requested review from WiemKhlifi

At least 2 approving reviews are required to merge this pull request.

Assignees

@SimonDuToit SimonDuToit

Labels
size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SimonDuToit @sash-a @OmaymaMahjoub @WiemKhlifi