chore: switched development version to v20 #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
commented
May 16, 2024
kirrg001
force-pushed
the
node20-dev
branch
4 times, most recently
from
eb31620
to
e2a9f38
Compare
kirrg001
commented
May 22, 2024
| @@ -29,7 +29,8 @@ spec: | |||
| value: "default-pipeline" | |||
| - name: skip-cache | |||
| value: $(params.skip-cache) | |||
|
|
|||
| - name: context | |||
| value: "node-dev" | |||
There was a problem hiding this comment.
Renaming the default pipeline for main and PR to "node-dev". Because the build name needs to be configured in Github as well (required build to pass). If we choose a generic name, we won't need to update anything when jumping to a higher Node.js version.
kirrg001
commented
May 22, 2024
| @@ -108,7 +108,7 @@ resources: | |||
| type: slack-notification | |||
| icon: slack | |||
| source: | |||
| url: ((tracer-community-slack-hook)) | |||
| url: ((team-nodejs-slack-hook)) | |||
There was a problem hiding this comment.
Added a new nodejs slack webhook.
|
I have already started to test the images. PR is RFR. |
aryamohanan
reviewed
May 23, 2024
kirrg001
force-pushed
the
node20-dev
branch
3 times, most recently
from
f0818e8
to
f72d084
Compare
aryamohanan
approved these changes
May 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs https://jsw.ibm.com/browse/INSTA-983
Now that we have resolved the issue with ESM and Node v18.18/v18.19, we can switch to Node v20.
Node v20 is LTS.