Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes in Chapter 7 #75

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Mingyu-Wei
Copy link
Contributor

@Mingyu-Wei Mingyu-Wei commented Mar 13, 2024

  • The output_path in sample python code is missing quotes
  • torch isn't properly imported
  • tokenizer should be loaded before loading dataset

@Mingyu-Wei Mingyu-Wei changed the title Add quotes for strings Some fixes in Chapter 7 Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant