Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Background: #10763
There exists shape error when run Qwen-7b or Qwen-14b using AutoTP.
The root cause is our
split_qkv_proj_func
not compatible with deepspeed splitting (https://github.com/microsoft/DeepSpeed/pull/4902/files).Take Qwen-14b for example, after deepspeed splitting, the shape of
c_attn_weight
is [7680, 5120], but still useprojection_size=5120
to split q/k/v.So change the
projection_size
to fix.4. How to test?