Upgrade Peft version to 0.10.0 for LLM finetune #10886
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qiyuangong
changed the title
|
Will upgrade peft version in other examples in other pull request. |
|
Revert changes in HF-PEFT finetune.py . |
|
Note that this PR will remove support for Peft 0.5.0. |
plusbang
reviewed
May 6, 2024
|
|
||
| self.fan_in_fan_out = fan_in_fan_out | ||
| self._active_adapter = adapter_name | ||
| self.update_layer( |
There was a problem hiding this comment.
It seems that we don't need to address case of qa_lora=True additionally?
There was a problem hiding this comment.
Peft doesn't add qalora support yet. huggingface/peft#986 We still need to handle qa_lora with our code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1. Why the change?
2. User API changes
3. Summary of the change
4. How to test?
5. New dependencies