Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apt install oneapi scripts #10891

Merged
merged 3 commits into from Apr 26, 2024
Merged

Conversation

liu-shaojun
Copy link
Contributor

@liu-shaojun liu-shaojun commented Apr 26, 2024

Description

1. Why the change?

This commit sets the apt installer as the default way to install OneAPI on Linux, for two reasons:

  • Firstly, we originally wanted users to install it via pip install because it's simpler. However, pip install only satisfies the runtime needs, not the compilation requirements. Some of our features, such as vLLM, require a compilation environment, which cannot be achieved through pip install.
  • Secondly, most of our internal colleagues require a compilation environment for development. Therefore, we need to maintain environments for both apt and pip installation methods. Providing a compilation environment only for certain machines would lead to resource contention and insufficient machine availability. Moreover, maintaining both methods simultaneously can cause confusion.

Therefore, for the sake of simplicity for users and colleagues, we have changed the default recommended method to apt installation.

Some users previously reported issues with apt installation method:
#10825
#10550
https://github.com/analytics-zoo/nano/issues/1230.
This commit also addresses the missing packages to resolve the issue of package absence.


.. code-block:: bash

sudo apt autoremove intel-oneapi-common-vars
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will this remove everything?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@liu-shaojun liu-shaojun merged commit d058f2b into intel-analytics:main Apr 26, 2024
@liu-shaojun liu-shaojun deleted the apt branch April 26, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants