Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sdp logic #10896

Merged
merged 2 commits into from Apr 28, 2024
Merged

Fix sdp logic #10896

merged 2 commits into from Apr 28, 2024

Conversation

gc-fu
Copy link
Contributor

@gc-fu gc-fu commented Apr 26, 2024

@gc-fu gc-fu requested review from jenniew and hkvision April 26, 2024 09:29
@hkvision hkvision requested a review from rnwang04 April 26, 2024 12:18
jenniew
jenniew approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@jenniew jenniew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gc-fu gc-fu merged commit c9fac8c into intel-analytics:main Apr 28, 2024
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenniew jenniew jenniew approved these changes

@hkvision hkvision hkvision approved these changes

@lalalapotter lalalapotter lalalapotter approved these changes

@rnwang04 rnwang04 rnwang04 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@gc-fu @jenniew @hkvision @lalalapotter @rnwang04