Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add try catch for old mfxInit call #132 #130

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

xelement
Copy link

Issue

We are an app with tens of millions of users,recently we found some crash report show that mfxInit throw unhandled exception which do not be catched on user device,just see dump file below.

image

Solution

just add try catch for mfxInit call

How Tested

try catch do not need test

dump:
3a0b8cfd-431a-4e62-8f13-6e3cc42156be.dmp

@xelement xelement force-pushed the bugfix/add-try-catch-for-mfxinit branch from a6bee7e to c9831a3 Compare April 29, 2024 14:13
Copy link
Contributor

@mav-intel mav-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR. A couple of requests:

  1. Please sign-off on the PR as indicated in CONTRIBUTING.md
  2. Please fix the code formatting to align with style guidance
  3. Please fix the commit message to align with style guidance. I recommend:
    Catch unhandled exceptions when calling old init

You can check formatting yourself by running script/test lint

Signed-off-by: Xelement Liu <xelementliu@tencent.com>
@xelement xelement force-pushed the bugfix/add-try-catch-for-mfxinit branch from c9831a3 to 613830a Compare May 3, 2024 16:39
@xelement xelement closed this May 3, 2024
@xelement xelement reopened this May 3, 2024
@xelement
Copy link
Author

xelement commented May 3, 2024

I'm sorry I didn't read the CONTRIBUTING.md,I've already modified it,issue#132

@xelement xelement requested a review from mav-intel May 3, 2024 16:46
@xelement xelement changed the title add try catch for real mfxInit call add try catch for old mfxInit call #132 May 3, 2024
@mav-intel
Copy link
Contributor

mav-intel commented May 6, 2024

How Tested

try catch do not need test

@xelement Can you confirm that you no longer see the exception thrown in your local environment after this change?

@xelement
Copy link
Author

xelement commented May 7, 2024

How Tested

try catch do not need test

@xelement Can you confirm that you no longer see the exception thrown in your local environment after this change?

It was not my local environment,it was feedback from our users. maybe we can hold this pr for sometime. Our latest app version already includes this change, but it will take some time to see if it has any effect

Copy link
Contributor

@mav-intel mav-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for results from local testing before moving forward

@jonrecker
Copy link
Contributor

It was not my local environment,it was feedback from our users. maybe we can hold this pr for sometime. Our latest app version already includes this change, but it will take some time to see if it has any effect

Thank you for the update. The attached dump file and the call stack in #132 do not include a reference to libvpl.dll, so it was not clear how this code is being called. Also the source code line numbers in the call stack seem to line up with the MediaSDK implementation of MFXInit() and MFXInitEx(), so perhaps that test was run using MediaSDK dispatcher (there is significant code in common). Any additional info about how this PR was validated would be helpful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants