-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add try catch for old mfxInit call #132 #130
base: main
Are you sure you want to change the base?
Conversation
a6bee7e
to
c9831a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. A couple of requests:
- Please sign-off on the PR as indicated in CONTRIBUTING.md
- Please fix the code formatting to align with style guidance
- Please fix the commit message to align with style guidance. I recommend:
Catch unhandled exceptions when calling old init
You can check formatting yourself by running script/test lint
Signed-off-by: Xelement Liu <xelementliu@tencent.com>
c9831a3
to
613830a
Compare
I'm sorry I didn't read the CONTRIBUTING.md,I've already modified it,issue#132 |
@xelement Can you confirm that you no longer see the exception thrown in your local environment after this change? |
It was not my local environment,it was feedback from our users. maybe we can hold this pr for sometime. Our latest app version already includes this change, but it will take some time to see if it has any effect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for results from local testing before moving forward
Thank you for the update. The attached dump file and the call stack in #132 do not include a reference to libvpl.dll, so it was not clear how this code is being called. Also the source code line numbers in the call stack seem to line up with the MediaSDK implementation of MFXInit() and MFXInitEx(), so perhaps that test was run using MediaSDK dispatcher (there is significant code in common). Any additional info about how this PR was validated would be helpful. |
Issue
We are an app with tens of millions of users,recently we found some crash report show that mfxInit throw unhandled exception which do not be catched on user device,just see dump file below.
Solution
just add try catch for mfxInit call
How Tested
try catch do not need test
dump:
3a0b8cfd-431a-4e62-8f13-6e3cc42156be.dmp