-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Bayesian Optimization for DLRover Brain #1119
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzlnew
changed the title
[WIP] Add Bayesian Optimization for DLRover Brain
WIP: Add Bayesian Optimization for DLRover Brain
May 13, 2024
yzlnew
changed the title
WIP: Add Bayesian Optimization for DLRover Brain
Add Bayesian Optimization for DLRover Brain
May 14, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1119 +/- ##
==========================================
+ Coverage 79.15% 79.28% +0.12%
==========================================
Files 204 207 +3
Lines 18168 18283 +115
==========================================
+ Hits 14381 14495 +114
- Misses 3787 3788 +1 ☔ View full report in Codecov by Sentry. |
LGTM |
yadandan
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Add a simple bayesian optimization implementation based on BoTorch for DLRover Brain.
Why are the changes needed?
Useful for black-box optimization scenario, like hyper-parameter search.
Does this PR introduce any user-facing change?
Only when user tries to use this method.
How was this patch tested?
By
test_hpsearch_bo.py
, but we can not control the randomness caused by the optimization of the acquisition function. This unit test could fail under a very rare circumstances.