Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bayesian Optimization for DLRover Brain #1119

Merged
merged 10 commits into from
May 20, 2024

Conversation

yzlnew
Copy link
Contributor

@yzlnew yzlnew commented May 13, 2024

What changes were proposed in this pull request?

Add a simple bayesian optimization implementation based on BoTorch for DLRover Brain.

Why are the changes needed?

Useful for black-box optimization scenario, like hyper-parameter search.

Does this PR introduce any user-facing change?

Only when user tries to use this method.

How was this patch tested?

By test_hpsearch_bo.py, but we can not control the randomness caused by the optimization of the acquisition function. This unit test could fail under a very rare circumstances.

@yzlnew yzlnew changed the title [WIP] Add Bayesian Optimization for DLRover Brain WIP: Add Bayesian Optimization for DLRover Brain May 13, 2024
@yzlnew yzlnew changed the title WIP: Add Bayesian Optimization for DLRover Brain Add Bayesian Optimization for DLRover Brain May 14, 2024
Copy link

codecov bot commented May 14, 2024

Codecov Report

Attention: Patch coverage is 99.13043% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 79.28%. Comparing base (27cb42a) to head (bb013eb).

Files Patch % Lines
dlrover/python/brain/hpsearch/base.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1119      +/-   ##
==========================================
+ Coverage   79.15%   79.28%   +0.12%     
==========================================
  Files         204      207       +3     
  Lines       18168    18283     +115     
==========================================
+ Hits        14381    14495     +114     
- Misses       3787     3788       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yadandan
Copy link
Collaborator

LGTM

@yzlnew yzlnew merged commit 1c19f42 into intelligent-machine-learning:master May 20, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants